BetterCC

Does this addon still work?

whats up with "to fix this" to fix what? is there any command to bring up a menu or something?

No, there are no GUI menus in game, Adalyn didn't make any, and also, this was last updated by him last october... To implement my fix so the colors fade properly, you have to edit the lua in an editor, I recommend Notepad++. (Which is different from standard Notepad, Notepad++ is a great free coding editor.)

To fix this:

Add under line 56:

local iconFrame = self.m_Windows[BASE_ICON]

Add under (new) line 95:

iconFrame:SetTintColor(100, 100, 100)

Add under (new) line 99:

iconFrame:SetTintColor(255, 255, 255)

I use Notepad to Edit. How am I supposed find "line 56" and "line 95"? Any help here would be appreciated.

Just click on View > Status Bar on the top menu (of Notepad) and you'll see the status bar at the bottom that tells you the Line and the Column.

thanks nKarnak!

But; is he talking about the "line 56" of "Code". or "line 56" from the top.

I guess it's line56 from the top (so when you see Ln56 on the Status Bar), but I'm not 100% sure ;)

(She actually :) lol)

Or just go download Notepad++ :D http://notepad-plus.sourceforge.net/uk/site.htm

But yes, lines from the top... If you guys need the lua emailed, just email me through my curse profile.

Any idea if this is going to be patched for 1.1? I like this better >.>

no longer works with 1.1a

I've put together an alternative implementation: [http://war.curse.com/downloads/war-addons/details/nhidegcd.aspx NHideGCD]

I've skipped over this addon a million times. So glad I finally gave it a shot. It's so simple, yet so great.

Adalyn

BetterCC is very well conceived - it is simple and works.

Unfortunately, the implementation makes my eyes bleed in shame. You have committed many common atrocities:

* Hooking without callback - don't just overwrite ActionButton.UpdateCooldownAnimation; let it do all the work then you make your modifications / changes afterwards. Not only is it silly to overwrite existing functionality with your own, but you break other addons that hook that method, like Wikki's Cooldown Pulse.
* Inefficiencies:
o Locals are used instead of constants i.e. BASE_ICON, BUTTON_TEXT etc. Don't instantiate and destroy them every time BetterCC.BetterCCAnim is called, make them file local, like DAY, HOUR, MINUTE.
o Excessive function overhead: CreateCooldownPulse doesn't do anything, so don't waste the overhead of a function call.
o Function locals used instead of file locals: cooldownFrame, timerFrame etc. should be file local, as BetterCCAnim is called often.
* Why am I obsessed with silly little inefficiency rules that I often break in my own addons? BetterCCAnim is called once every frame - that's around a hundred times a second - LUA is not efficient, so you need to do your best to make it as quick as possible.
* You work against OO LUA - please work with it: use BetterCC:BetterCCAnim(timeElapsed, updateCooldown). This will help you out when you're implementing my first point - hooking after the callback.
* Checking silly conditions: are there really spells with cooldowns greater than a day? If there aren't, don't bother checking - the default UI sees no need to.

I'm happy to assist you with any changes, updates and future revisions of BetterCC.


Nemes

Does that mean you are going to fix this amazing mod so it plays nice with the other mods!

Adalyn: I can refactor / massage this addon into happiness. I can then either hand it over to you or host it myself... up to you.

Currently, your mod somehow conflicts with both BetterCC and Wikki's Cooldown Pulse. Not sure why, but sure makes using the mods frustrating!

It doesn't conflict with your own, but Ability Alert! Durrrrrrr! The author of Wikki's made a comment concerning function issues or something like that.

Recently stopped working for me, I have no idea why!