NPC Item Sale Price

For some reason certain items for Rally Rewards do not display a tooltip box on mouseover, but only with this add-on?

Like, I will be choosing a rally reward for the middle tier, and the first 2 left-most rewards will show tooltips and NPC sell prices. However the third one will show no tool-tips at all. And I cannot pick it.

Is it possible to add additional funcationality for a stack of items? ie List the sell price of the stack, and also the price of an individual item?

Seconded! Loved that functionality in WoW.

I get the following error message whenever the addon loads:
Unable to open file: user/interface/AllCharacters/NPC Item Sale Price/SavedVariables.lua

This addon is nicely settled down - is it time to remove debug mode and the SVs?

Yeah, I've been seeing the same error. I think it only shows up in the /debug trace, though? So it's pretty benign. Looking into it, the SavedVariables.lua is exactly where it should be, but it's empty and size 0. I don't know much about the save/restore mechanism. I'm guessing it's crapping out when it tries to save the variables because one of them is 'DumpItemsTable', which is a table that gets initialized to {} but never used unless you actually do some debugging. I think that code was only put in there to try to diagnose the mysterious price difference bug (since fixed), so it could probably go. I don't know if Sniperumm is inclined to try and fix it up, I suppose I could. A quick hack solution is to leave the .lua file alone and remove the 'DumpItemsTable' variable from the nisp.mod's list of saved variables. I haven't tested that yet, but I suspect it will work. The SVs can't just be totally removed because they remember whether the module is enabled or not. Mind you I don't know why you'd have this installed if you disabled it, it doesn't do anything else! :-)

The enable/disable slash commands aren't necessary - it can be disabled via the ingame menu or by uninstalling. Unnecessary configuration leads to Microsoft style bloatware.

LibSlash and SV can be removed.

OK, I spent the night really digging into it, and managed to figure it all out and even fix & test the code :-) I'm sending a ready-to-go version of the changes to Sniperumm, and hopefully he can put up an update here soon.

The basic mystery was that if you point your mouse at an item which is equippable (i.e. weapons & armor), you will generate TWO tooltips whenever you have an item equipped in that slot for comparison purposes. The code was displaying the price of the item you have equipped, not the one you're mousing over. I managed to clean that up & make it work nice with even multiple comparison items (like jewelry using preciousss!) and to handle broken items much more cleanly that it was doing before... Note the the slash interface also didn't work any more in v3.1.2 due to UI changes. That's now fixed as well.

Made some discoveries that may help in fixing this.

Item tooltips on the player window (equiped items) are showing the same sell value at merchant and away (while they are equiped).

If you drag an armor or weapon item to the hotbar, THAT tooltip shows the same sell value at merchant and away.

Seems to only be affecting armor and weapon tooltips while the item is moused over inside the backpack. This made me think it was another addon messing things up so I disabled them all but had no change.

Ive looked through the Backpack code, the InteractionStore code, and the Tooltip code. I cant find anything.

If it's right for everything but armor & weapons, how about then you just patch it to disable showing any values for those types of items, and leave in it for everything else? That way it won't confuse anyone when it's wrong, and still be very useful when it's right. I'm starting to get annoyed trying to remember when I can trust this thing & when I can't...

The Merchant and the debug generated lua file both show the same value. Its only the in-game NISP enhanced tooltip that is showing a different value, and thats only happening for equipable items.

The math for the phenomenon does not add up correctly to suggest sell bonus. Some items are up, some are down (at the same merchant).

Its gotta be a bug in Mythic's code when trying to request sell value away from a merchant. Ive looked over their code for backpack and item tooltips and cant find any odd function calls or weird calculations for the sell value.

Good luck Sniperumm.

Pure guessing: maybe there's a problem with prices when buy and sell bonuses are active in an area?

Another thing: it might help if anyone who spots the difference in prices could check which price is correct merchant's or NISP's by checking the difference between money before and after selling. It might be that merchant's price is messed up, not NISP's.

The items are all armor or weapon types. All other price values are the same as shown at a merchant. I have yet to come across a gear type item where NISP and the merchant show the same value.

Something is happening to the tooltip itself as a result of NISP "hooking" it, and its only doing it for gear type items.

NISP gives incorrect sell prices for gear items. I got a few items in my inventory and used the debug method to get the item info. When I looked at the SavedVariables file, all the prices were the same as they were on the in-game merchant. I'll repeat, away from the store NISP shows the wrong price but the SavedVariables file shows the correct price. Its just the actual NISP tooltip that is "showing" the wrong price.

Item / merch / NISP
itemA / 6.64 / 7.56
itemB / 13.92 / 8.83
itemC / 16.2 / 12
itemD / 15.7 / 9.6

NISP prices some gear too high and some too low. I cant find a pattern, but something is altering the "shown" price away from merchants. NISP is GETTING the correct price, but its just showing some modified amount.

NISP seems to price gear incorrectly. On my current character, with no zone bonus for merchant, here is what I see (price is real/NISP):

Initiate's Lash: 1s68c/4s20c
Gale Runner's Softsoles: 4s80c/1s92c
Gale Runner's Emberstaff: 6s/4s80c

As can be seen, the real sell price is always higher but not by any set amount or percent that I can see.